watcher: stop serving the watchlist's stored fd to --hot reload reads - #37050
Merged
Claude / Claude Code Review
completed
Aug 6, 2026 in 31m 39s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/AsyncModule.rs:1288-1290 |
ParseResult::input_fd is now a dead field |
Annotations
Check warning on line 1290 in src/jsc/AsyncModule.rs
claude / Claude Code Review
ParseResult::input_fd is now a dead field
Removing the deferred watcher re-add here (and the `AsyncModule`/`InitOpts` fields that fed it) leaves `ParseResult::input_fd` with no readers anywhere in the codebase — it's now written at every construction site and threaded through `parse_data_loader`/`parse_text_loader`/`parse_md_loader`/`parse_wasm_loader`/`ParseResult::file` as a pass-through parameter, but never read. Per REVIEW.md ("Delete dead code in the same PR that makes it dead — required scope: fields nothing reads, parameters disc
Loading