Fix exception handling in unwrapBoxedPrimitive - #37025
Merged
Merged
Claude / Claude Code Review
completed
Aug 6, 2026 in 11m 11s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/yaml/yaml.test.ts:4293-4296 |
Subprocess test pipes stderr but never drains it |
Annotations
Check warning on line 4296 in test/js/bun/yaml/yaml.test.ts
claude / Claude Code Review
Subprocess test pipes stderr but never drains it
This test sets `stderr: "pipe"` but the `Promise.all` only drains stdout and awaits exit — stderr is never read. Add `proc.stderr.text()` to the `Promise.all` and assert it's empty (or drop `stderr: "pipe"`); on a regressed build the `releaseAssertNoException` dump goes to stderr, so as written the failure would show only an opaque stdout mismatch with the actual diagnostic discarded.
Loading