node:crypto: implement argon2 and argon2Sync - #37015
Merged
Merged
Claude / Claude Code Review
completed
Aug 6, 2026 in 18m 41s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/js/node/crypto.ts:347 |
Dead error code ERR_CRYPTO_ARGON2_NOT_SUPPORTED left in ErrorCode.ts |
Annotations
Check warning on line 347 in src/js/node/crypto.ts
claude / Claude Code Review
Dead error code ERR_CRYPTO_ARGON2_NOT_SUPPORTED left in ErrorCode.ts
This PR removes the last two callers of `$ERR_CRYPTO_ARGON2_NOT_SUPPORTED` (and the test that asserted it), so the registration entry `["ERR_CRYPTO_ARGON2_NOT_SUPPORTED", Error]` at `src/jsc/bindings/ErrorCode.ts:359` is now dead. Per REVIEW.md ("Delete dead code in the same PR that makes it dead"), that ErrorCode.ts line should be dropped in this PR.
Loading