Remove dead code from jsc FFI glue, C++ bindings, bun_core, http_types, and bunfig - #37012
Open
robobun wants to merge 11 commits into
Open
Remove dead code from jsc FFI glue, C++ bindings, bun_core, http_types, and bunfig#37012robobun wants to merge 11 commits into
robobun wants to merge 11 commits into
Claude / Claude Code Review
completed
Aug 6, 2026 in 22m 1s
Code review found 3 potential issues
Found 1 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 3 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/bun_core/fmt.rs:706-711 |
Stale [raw] intra-doc link on fmt::s() after removing fmt::raw |
Annotations
Check warning on line 711 in src/bun_core/fmt.rs
claude / Claude Code Review
Stale [`raw`] intra-doc link on fmt::s() after removing fmt::raw
Removing `pub const fn raw` here left a stale intra-doc reference on the retained `s()` function at src/bun_core/fmt.rs:3474, whose doc reads "short alias of [`raw`] for terse call sites". The [`raw`] link now points at a deleted item (broken rustdoc intra-doc link) and the description is inverted — `s` is no longer an alias of anything. Fix: change the doc on `s()` to reference [`Raw`] (the struct, which the PR retained) instead of the deleted [`raw`] fn — e.g. "Zero-validation `&[u8] -> impl D
Loading