node:http: queue pipelined responses on fallback connections instead of throwing ERR_HTTP_SOCKET_ASSIGNED - #36991
Open
robobun wants to merge 8 commits into
Open
node:http: queue pipelined responses on fallback connections instead of throwing ERR_HTTP_SOCKET_ASSIGNED#36991robobun wants to merge 8 commits into
robobun wants to merge 8 commits into
Claude / Claude Code Review
completed
Aug 6, 2026 in 32m 34s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/js/internal/http1_server_fallback.ts:476-482 |
Fallback socket 'close' aborts queued requests but not the in-flight one |
Annotations
Check warning on line 482 in src/js/internal/http1_server_fallback.ts
claude / Claude Code Review
Fallback socket 'close' aborts queued requests but not the in-flight one
nit: the fallback `'close'` listener now aborts *queued* pipelined responses, but it still doesn't abort the *in-flight* request — the native `#onClose` this comment says it mirrors also does `this._httpMessage?.req.destroy(new ConnResetException('aborted'))` (lines 1703-1714), and Node's `socketOnClose` → `abortIncoming` does the same. `onServerResponseClose` (installed by `assignSocket`) only closes the *response*, so on a `serverSide.destroy()` the in-flight `IncomingMessage` never emits `'ab
Loading