cli: match bunx/node invocation names case-insensitively - #36827
Open
robobun wants to merge 14 commits into
Open
cli: match bunx/node invocation names case-insensitively#36827robobun wants to merge 14 commits into
robobun wants to merge 14 commits into
Claude / Claude Code Review
completed
Aug 15, 2026 in 10m 33s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/cli/run/as-node.test.ts:122-140 |
test.concurrent.each with Bun.spawnSync provides no concurrency |
Annotations
Check warning on line 140 in test/cli/run/as-node.test.ts
claude / Claude Code Review
test.concurrent.each with Bun.spawnSync provides no concurrency
The `.concurrent` here is a no-op: the callback is synchronous (`name => { ... }`) and its only I/O is `Bun.spawnSync`, which blocks the event loop until the child exits, so there is no yield point for the two cases to interleave — they still run serially. To make the concurrency real, mirror the sibling test in `bunx.test.ts` (async `Bun.spawn` + `await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited])`); REVIEW.md's harness conventions also list "async spawns over `spawnSync`"
Loading