node:fs: keep ArrayBuffer storage alive across worker.terminate() during async write - #36818
Open
robobun wants to merge 7 commits into
Open
node:fs: keep ArrayBuffer storage alive across worker.terminate() during async write#36818robobun wants to merge 7 commits into
robobun wants to merge 7 commits into
Claude / Claude Code Review
completed
Aug 3, 2026 in 14m 5s
Code review found 1 important issue
Found 1 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/node/fs/fs-write-worker-terminate.test.ts:98 |
Explicit 30s per-test timeout violates test/CLAUDE.md |
Annotations
Check warning on line 98 in test/js/node/fs/fs-write-worker-terminate.test.ts
claude / Claude Code Review
Explicit 30s per-test timeout violates test/CLAUDE.md
The explicit `30_000` per-test timeout conflicts with test/CLAUDE.md:120 ("**CRITICAL**: Do not set a timeout on tests"). If the default suffices under debug+ASAN, drop it; if it doesn't (this ASAN-only subprocess→worker→FIFO test with a 5s worker-readiness race is a plausible outlier), add a one-line comment naming the observed wall-clock so it reads as the deliberate exception the root CLAUDE.md permits.
Loading