worker: guard the remaining NewSocket / ServerWebSocket / Bun.serve / Bun.$ dispatch sites against a pending termination - #36808
Open
robobun wants to merge 9 commits into
Open
Claude / Claude Code Review
completed
Aug 3, 2026 in 16m 28s
Code review found 2 potential issues
Found 1 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/runtime/socket/Listener.rs:1716-1717 |
Stale doc comment on WindowsNamedPipeListeningContext::vm field |
Annotations
Check warning on line 1717 in src/runtime/socket/Listener.rs
claude / Claude Code Review
Stale doc comment on WindowsNamedPipeListeningContext::vm field
nit: the `vm` field's doc comment two lines up ("`&'static` so call sites read `self.vm.is_shutting_down()` without a raw-pointer deref") uses `is_shutting_down()` as its example, but 801fd3a changed this call site to `script_execution_status() != Running`. The substantive point (why `&'static` rather than a raw pointer) is still correct — only the example method name is stale. Same class as the open mod.rs:560/1771 doc-comment nit; could be swept together. Comment-only, no runtime effect.
Loading