Remove dead code from webcore C++, highway_strings, inspector agents, InlineBlob, Ipc.ts - #36791
Merged
Jarred-Sumner merged 11 commits intoAug 3, 2026
Merged
Claude / Claude Code Review
completed
Aug 2, 2026 in 29m 41s
Code review found 7 potential issues
Found 4 candidates, confirmed 7. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 7 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/bindings/InspectorLifecycleAgent.cpp:84-89 |
LifecycleReporter.reload consumers orphaned; not listed in Followups |
| 🟡 Nit | src/jsc/bindings/webcore/JSWorkerOptions.cpp:43-44 |
Orphaned commented-out #includes in JSWorkerOptions.cpp and JSEventListener.cpp |
Annotations
Check warning on line 89 in src/jsc/bindings/InspectorLifecycleAgent.cpp
claude / Claude Code Review
LifecycleReporter.reload consumers orphaned; not listed in Followups
The Followups section lists `BunFrontendDevServerFrontendDispatcher::clientErrorReported`/`graphUpdate` as now-unreferenced protocol dispatchers, but omits the identically-situated `LifecycleReporterFrontendDispatcher::reload()` — after this diff, `rg "frontendDispatcher->reload"` = 0 hits. Same-class orphaned consumers worth folding into that Followup (or deleting now, since they were already inert pre-PR): `packages/bun-vscode/src/features/diagnostics/diagnostics.ts:127-129` (`debugAdapter.on(
Check warning on line 44 in src/jsc/bindings/webcore/JSWorkerOptions.cpp
claude / Claude Code Review
Orphaned commented-out #includes in JSWorkerOptions.cpp and JSEventListener.cpp
Two more orphaned commented-out `#include` lines whose only consumer was a block this PR just removed: `JSWorkerOptions.cpp:26-27` (`// #include "JSFetchRequestCredentials.h"` / `// #include "JSWorkerType.h"` — existed only for the removed `credentials`/`type` parsing) and `JSEventListener.cpp:24` (`// #include "BeforeUnloadEvent.h"` — existed only for the removed `handleBeforeUnloadEventReturnValue` helper). Same incomplete-cascade pattern already fixed in 4b9495de88 for JSTextEncoder's DOMJIT
Loading