Skip to content

Intl.Locale: apply CLDR alias mappings during canonicalization - #36731

Open
robobun wants to merge 6 commits into
mainfrom
farm/b450b143/intl-locale-canonicalize
Open

Intl.Locale: apply CLDR alias mappings during canonicalization#36731
robobun wants to merge 6 commits into
mainfrom
farm/b450b143/intl-locale-canonicalize

ci: retrigger

d9db064
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Aug 1, 2026 in 17m 8s

Code review found 1 important issue

Found 3 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 1
🟡 Nit 0
🟣 Pre-existing 0
Severity File:Line Issue
🔴 Important scripts/build/deps/webkit.ts:6 WEBKIT_VERSION pinned to ephemeral preview PR build

Annotations

Check failure on line 6 in scripts/build/deps/webkit.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

WEBKIT_VERSION pinned to ephemeral preview PR build

`WEBKIT_VERSION` is pinned to `autobuild-preview-pr-381-edc9ed33`, an ephemeral preview release that GitHub deletes as soon as oven-sh/WebKit#381 merges or closes — at which point every fresh checkout/CI build 404s downloading WebKit. Per the repo's own workflow (`.claude/commands/upgrade-webkit.md`), the WebKit PR must land first and this must be bumped to the resulting merge-commit sha (`autobuild-<sha>`) before this Bun PR is merged.