-
Notifications
You must be signed in to change notification settings - Fork 5k
Provide a better-sqlite3 module backed by bun:sqlite
#36712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robobun
wants to merge
20
commits into
main
Choose a base branch
from
farm/cbc46e92/better-sqlite3-shim
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d28f020
Provide a better-sqlite3 module backed by bun:sqlite
robobun 0657c5f
[autofix.ci] apply automated fixes
autofix-ci[bot] 443ee5b
Tighten comments in better-sqlite3 shim
robobun c7ef033
Collapse module header to a single line
robobun 3e0e897
Address review: fix .raw().iterate() with duplicate column names
robobun d59c653
Address coderabbit review: id-0 match, verbose, unsafeMode, tests
robobun d39ce9f
Open bun:sqlite with strict: true so named params match better-sqlite3
robobun 47a0b30
Drop dead state and collapse all()/get()/iterate() to one mapRow path
robobun a8367b8
declaredTypes: drop the hasExecuted guard; tidy hasInstance and crash…
robobun 340368c
Lazy-require node:util for inspect; use bun.com docs URL
robobun bae77a9
iterate(): validate bound parameters at call time, not on first next()
robobun 69396d3
exec(): no-op on empty/comment-only input; update declaredTypes docs
robobun f50d995
Refuse read methods on non-reader statements; trace expanded SQL
robobun f2cc60b
Trace in finally so failing statements are still logged; cache column…
robobun ca2f612
Guard the verbose callback; snapshot TypedArrays in .bind()
robobun 166cc71
bind(): narrow snapshot guard to Uint8Array (Buffer.from is element-w…
robobun 01dc6c8
ci: retrigger
robobun 8fb5753
close() finalizes outstanding prepared statements
robobun 6cf828f
Track prepared statements via WeakRef so GC can reclaim them before c…
robobun 0ae892b
Prune dead WeakRefs from the statements Set via FinalizationRegistry
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.