install: restore the slow-lifecycle-script warning from #7719 - #36587
Open
robobun wants to merge 5 commits into
Open
install: restore the slow-lifecycle-script warning from #7719#36587robobun wants to merge 5 commits into
robobun wants to merge 5 commits into
Claude / Claude Code Review
completed
Aug 1, 2026 in 12m 2s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/install/PackageManager/PackageManagerLifecycle.rs:64-70 |
Trailing \n in warn! does not produce the intended blank line |
Annotations
Check warning on line 70 in src/install/PackageManager/PackageManagerLifecycle.rs
claude / Claude Code Review
Trailing \n in warn! does not produce the intended blank line
The comment says "extra \\n prints a blank line after this one", but `bun_core::warn!` expands to `pretty_errorln!`, whose `_needs_nl()` helper returns `""` when the format string already ends in `\n` (the `ln_macros_suppress_double_newline` unit test in output.rs pins this exact case). So exactly one newline is emitted and the intended blank-line separator before "N packages installed" doesn't appear. Either drop the trailing `\n` and the misleading comment (matching the sibling `report_slow_li
Loading