install: restore the slow-lifecycle-script warning from #7719 - #36587
Open
robobun wants to merge 5 commits into
Open
install: restore the slow-lifecycle-script warning from #7719#36587robobun wants to merge 5 commits into
robobun wants to merge 5 commits into
Claude / Claude Code Review
completed
Aug 1, 2026 in 14m 59s
Code review found 1 important issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | src/install/PackageManager/PackageManagerLifecycle.rs:53-60 |
Release build failure: Mutex::try_lock is #[cfg(debug_assertions)]-gated |
Annotations
Check failure on line 60 in src/install/PackageManager/PackageManagerLifecycle.rs
claude / Claude Code Review
Release build failure: Mutex::try_lock is #[cfg(debug_assertions)]-gated
This breaks release builds: `bun_threading::Mutex::try_lock` is `#[cfg(debug_assertions)]`-gated (src/threading/Mutex.rs:53), so the method does not exist when `debug_assertions` is off, and `if IS_DEBUG { debug_assert!(...) }` is a runtime const-if whose body is still type-checked. Wrap the block in `#[cfg(debug_assertions)] { ... }` instead (as every other `bun_threading::Mutex::try_lock` call site in-tree does); `bun run rust:check-all` didn't catch this because it only runs `cargo check` in
Loading