Remove dead code from C++ bindings (ErrorCode, JSX509CertificateConstructor, JSDOMWrapperCache) and bun_core - #36500
Merged
Jarred-Sumner merged 7 commits intoJul 31, 2026
Claude / Claude Code Review
completed
Jul 31, 2026 in 13m 14s
Code review found 2 potential issues
Found 1 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/bindings/JSDOMWrapperCache.h:43 |
getDOMPrototype forward declaration is another never-defined sibling |
Annotations
Check warning on line 43 in src/jsc/bindings/JSDOMWrapperCache.h
claude / Claude Code Review
getDOMPrototype forward declaration is another never-defined sibling
Line 43's `getDOMPrototype(JSC::VM&, JSC::JSGlobalObject*)` forward declaration is another declared-never-defined sibling: the actual definition at line 87 takes `JSDOMGlobalObject&` (reference to derived, not pointer to base), so line 43 declares a distinct overload that nothing calls or defines — the exact class you just removed `getOrCreateWrapper` for one hunk away. Same for the `wrap(JSC::JSGlobalObject*, DOMWrapperWorld&, DOMClass&)` decl at line 67 (only the `JSDOMGlobalObject*` overload
Loading