Skip to content

ci(runner): run test-fs-read-stream-pos.js serially with a 120s ceiling #36478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 4 commits into from
Jul 31, 2026
Merged

ci(runner): run test-fs-read-stream-pos.js serially with a 120s ceiling #36478

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e70ddff
ci(runner): run test-fs-read-stream-pos.js serially with a 120s ceiling
robobun Jul 30, 2026
8e39fd2
ci: retrigger
robobun Jul 30, 2026
337c48a
ci(runner): scope the 1-40s solo claim to Windows; cite aarch64 CI re…
robobun Jul 30, 2026
af28a9a
revert: drop accidentally staged test-fs-filehandle.js
robobun Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion scripts/runner.node.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,12 @@ function getNodeParallelTestTimeout(testPath) {
if (testPath.includes("test-cluster-")) return 60_000; // cluster IPC + socket-handle passing is process-heavy under runner concurrency
if (testPath.includes("-docker-")) return 60_000;
if (testPath.includes("test-stdin-pipe-large")) return 60_000; // pipes 1MB stdin->stdout through an extra child process; slow under runner concurrency
// test-fs-read-stream-pos.js exit condition is a pure timing race (writer must append
// between two consecutive ReadStream preads) with a 90s upstream safety timer; solo
// runtimes are ~1s on linux-x64 but 1-40s on Windows since #34834 raised its timer
// resolution, and aarch64 CI retries running alone have exceeded 20s (builds 85866,
// 85400). 120s lets the safety timer fire.
if (testPath.includes("test-fs-read-stream-pos")) return 120_000;
if (!isCI) return 60_000; // everything slower in debug mode
if (options["step"]?.includes("-asan-")) return 60_000;
return 20_000;
Expand Down Expand Up @@ -634,7 +640,14 @@ async function runTests() {
const parallelSafeLimit = parallelism > 1 ? limit : pLimit(parallelSafeWidth);
const isParallelSafeTest = testPath => {
const p = testPath.replaceAll("\\", "/");
return p.includes("js/node/test/parallel/") || p.includes("js/bun/test/parallel/");
if (!p.includes("js/node/test/parallel/") && !p.includes("js/bun/test/parallel/")) return false;
// test-fs-read-stream-pos.js arms a common.mustCallAtLeast per stream; under
// I/O-heavy neighbours (e.g. test-fs-read-stream-fd-leak) the 1ms append
// interval is starved long enough for a stream to catch cur == EOF and get
// zero 'data' events, failing the mustCallAtLeast check on exit. Run it in
// the serial phase so the writer keeps its 1ms cadence.
if (p.endsWith("test-fs-read-stream-pos.js")) return false;
return true;
};
console.log("parallel-safe width", parallelSafeWidth);
const validationApplies = basename(execPath).includes("asan") || !isCI;
Expand Down
Loading