Skip to content

Remove dead code from SerializedScriptValue, WebSocket, Performance, JSDOMConvert*, rescle, wasi - #36474

Merged
Jarred-Sumner merged 10 commits into
mainfrom
claude/farm/3e237919/dead-code-ssv-wasi-webcore
Aug 1, 2026
Merged

Remove dead code from SerializedScriptValue, WebSocket, Performance, JSDOMConvert*, rescle, wasi#36474
Jarred-Sumner merged 10 commits into
mainfrom
claude/farm/3e237919/dead-code-ssv-wasi-webcore

Delete test/internal/source-lints/dead-symbols-ssv-wasi-webcore.test.ts

11bdeca
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Aug 1, 2026 in 11m 22s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit src/jsc/bindings/webcore/SerializedScriptValue.h:109 Source-lint guard test deleted; PR description/evidence gate now stale

Annotations

Check warning on line 109 in src/jsc/bindings/webcore/SerializedScriptValue.h

See this annotation in the file changed.

@claude claude / Claude Code Review

Source-lint guard test deleted; PR description/evidence gate now stale

Commit 11bdeca3 (HEAD) deletes `test/internal/source-lints/dead-symbols-ssv-wasi-webcore.test.ts` — the only test this PR added — with a bare commit message and no timeline note, so the diff is now 29 files with no test. The PR description's Verification section and the entire `robobun:evidence` gate block still claim this test "fails (7/7) with `src/` at `main`, passes (7/7) with this diff", which now overstates what ships. Either restore the test (updating its patterns after 63bfbb24 restored