console: apply group indent to count/time/assert and no-args log paths - #36470
Open
robobun wants to merge 5 commits into
Open
console: apply group indent to count/time/assert and no-args log paths#36470robobun wants to merge 5 commits into
robobun wants to merge 5 commits into
Claude / Claude Code Review
completed
Jul 30, 2026 in 19m 18s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/ConsoleObject.rs:5788-5790 |
console.assert(false) with no message still not indented inside console.group — same-class sibling missed |
Annotations
Check warning on line 5790 in src/jsc/ConsoleObject.rs
claude / Claude Code Review
console.assert(false) with no message still not indented inside console.group — same-class sibling missed
Same bug class, sibling site: bare `console.assert(false)` (no message args) inside a `console.group()` still prints `Assertion failed` at column 0 — the `MessageType::Assert && len == 0` early return at [ConsoleObject.rs:419-432](../blob/HEAD/src/jsc/ConsoleObject.rs#L419-L432) writes directly to `error_writer()` and returns before `default_indent` is read. The `len == 0` fallthroughs at lines 543-551 (bare `console.log()` → `\n`, other types → `undefined\n`) share the same shape. Per REVIEW.md
Loading