bun test: don't park the event loop after a test file's entry promise settles - #36453
Merged
Jarred-Sumner merged 6 commits intoJul 31, 2026
Merged
Claude / Claude Code Review
completed
Jul 30, 2026 in 12m 51s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/regression/issue/36450.test.ts:59-60 |
Subprocess failure diagnostics hidden by assertion order |
Annotations
Check warning on line 60 in test/regression/issue/36450.test.ts
claude / Claude Code Review
Subprocess failure diagnostics hidden by assertion order
If the child process fails (e.g. the fixture guard at line 32-34 throws, or the subprocess crashes), `expect(gaps).toHaveLength(fileCount)` trips first and prints only the numeric gap array — the captured `stderr` containing the actual error is never surfaced. Consider asserting a combined `{ gaps, stderr, exitCode }` object (per REVIEW.md's subprocess-test guidance) so failures self-diagnose, e.g. `expect({ gapCount: gaps.length, exitCode, stderr }).toEqual({ gapCount: fileCount, exitCode: 0, s
Loading