test: measure memory via harness rss() instead of process.memoryUsage.rss() - #36429
Merged
Claude / Claude Code Review
completed
Jul 30, 2026 in 7m 53s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/web/timers/setInterval-leak-fixture.js:8-11 |
Missing typeof Bun guard breaks Node compat on darwin |
Annotations
Check warning on line 11 in test/js/web/timers/setInterval-leak-fixture.js
claude / Claude Code Review
Missing typeof Bun guard breaks Node compat on darwin
This fixture is written to be Node-compatible (it polyfills `Promise.withResolvers` and guards `typeof Bun !== "undefined"` in `gc()`), but the new `usage` const evaluates `typeof Bun.unsafe.memoryFootprint` without a `typeof Bun !== "undefined"` guard — under Node on darwin this throws `ReferenceError: Bun is not defined` at load. The two sibling timer fixtures updated in this PR (`setinterval-cancel-fixture.js`, `setTimeout-clear-in-callback-leak-fixture.js`) both received the guard; this one
Loading