Remove dead code from webcore C++, ZigSourceProvider, react_compiler, bun_core/fmt - #36390
Merged
Jarred-Sumner merged 6 commits intoJul 30, 2026
Claude / Claude Code Review
completed
Jul 30, 2026 in 15m 43s
Code review found 2 potential issues
Found 5 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/bindings/ConsoleObject.cpp:108-110 |
Sibling files retain same-class dead code after sweep: ConsoleObject.cpp Inspector*Agent includes and EventPath.h |
| 🟡 Nit | test/internal/source-lints/dead-symbols-webcore-commented.test.ts:62-68 |
PR description stale again after merge 873f9ee: still says 21 files and lists deletions main already removed |
Annotations
Check warning on line 110 in src/jsc/bindings/ConsoleObject.cpp
claude / Claude Code Review
Sibling files retain same-class dead code after sweep: ConsoleObject.cpp Inspector*Agent includes and EventPath.h
Two more same-class leftovers in sibling files of ones this PR swept: (1) `ConsoleObject.cpp:18-20` still `#include` `InspectorScriptProfilerAgent.h`/`InspectorDebuggerAgent.h`/`InspectorConsoleAgent.h` — after the agent fields/aliases were removed from `ConsoleObject.{h,cpp}`, nothing references those types (surviving code only uses `inspectorController().consoleClient()`); (2) `webcore/EventPath.h` — the paired header of the swept `EventPath.cpp` — still has `// #include "PseudoElement.h"`/SVG
Check warning on line 68 in test/internal/source-lints/dead-symbols-webcore-commented.test.ts
claude / Claude Code Review
PR description stale again after merge 873f9ee: still says 21 files and lists deletions main already removed
The PR description is stale again after merge 873f9ee: it still says "-3446 / +93 across 21 files" and the Rust section still lists `CountingWriter`/`Null`, `parse_num` (+ the `bun_core/lib.rs` re-export), `ProgramContext::{is_already_compiled, mark_compiled}`/`already_compiled`, and `css: MediaList::clone_in` — but per your own merge comment ("Now 18 files, -3366/+91") main removed those independently and `src/bun_core/lib.rs`, `src/css/media_query.rs`, `src/react_compiler/imports.rs` are no lo
Loading