Bump WebKit: omit dayPeriod from Intl.DateTimeFormat resolvedOptions for bare 12-hour patterns - #36361
Open
robobun wants to merge 1 commit into
Open
Bump WebKit: omit dayPeriod from Intl.DateTimeFormat resolvedOptions for bare 12-hour patterns#36361robobun wants to merge 1 commit into
robobun wants to merge 1 commit into
Claude / Claude Code Review
completed
Jul 29, 2026 in 11m 45s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/web/intl/intl.test.ts:99-123 |
Test asserts CLDR-dependent literal output on all platforms |
Annotations
Check warning on line 123 in test/js/web/intl/intl.test.ts
claude / Claude Code Review
Test asserts CLDR-dependent literal output on all platforms
nit: This test hardcodes the CLDR-derived literals `"10:05 AM"` and `p.value === "AM"` under plain `test()`, while every other exact-output check in this file is gated by `snapshotIf` per the file header (macOS links Apple's libicucore, Windows a different ICU build). The invariants actually under test are CLDR-independent — consider asserting `roundTrip: a.format(t)` (equality, not a literal) and locating the formatToParts entry by `p.type === "dayPeriod"` rather than by value.
Loading