ci(build): keep waiting for build-cpp while a retry is queued instead of bailing on a stale errored outcome - #36339
Open
robobun wants to merge 6 commits into
Open
ci(build): keep waiting for build-cpp while a retry is queued instead of bailing on a stale errored outcome#36339robobun wants to merge 6 commits into
robobun wants to merge 6 commits into
Claude / Claude Code Review
completed
Jul 29, 2026 in 13m 34s
Code review found 2 potential issues
Found 1 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/internal/ci-sibling-wait.test.ts:40-45 |
Fake buildkite-agent stub depends on system node being on PATH |
Annotations
Check warning on line 45 in test/internal/ci-sibling-wait.test.ts
claude / Claude Code Review
Fake buildkite-agent stub depends on system node being on PATH
The fake `buildkite-agent` stub shells out to `node -e` to read `script.json`, but system `node` is not a repo invariant (`harness.ts` returns `which("node") || null`, and REVIEW.md requires `skipIf` when a system binary is unavailable). On a runner without node the stub exits non-zero on every call, `get()` returns `{ok:false}`, and the poll spins at 5 ms against the hardcoded 60-minute `deadlineMs` until the test times out with no useful message. Prefer passing `bunExe()` in via env and using
Loading