paths: terminate recursive mkdir walk when a confirmed parent still yields ENOENT - #36162
Open
robobun wants to merge 13 commits into
Open
paths: terminate recursive mkdir walk when a confirmed parent still yields ENOENT#36162robobun wants to merge 13 commits into
robobun wants to merge 13 commits into
Claude / Claude Code Review
completed
Jul 28, 2026 in 18m 31s
Code review found 2 potential issues
Found 1 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/install/PackageManager/PackageManagerDirectories.rs:338-343 |
Implicit-cache fallback warn is not gated on log_level != Silent |
Annotations
Check warning on line 343 in src/install/PackageManager/PackageManagerDirectories.rs
claude / Claude Code Review
Implicit-cache fallback warn is not gated on log_level != Silent
Nit: this warn is the only non-fatal informational print in the file that isn't gated on `log_level != LogLevel::Silent` (cf. "Slow filesystem detected" a few lines up, "Saved lockfile" / "failed to delete empty lockfile" in `save_lockfile`) or on `verbose_install()` (the tempdir-fallback warns). It's also a small behavioral change from the pre-PR silent `Err(_)` arm — `bun install --silent` with an unwritable implicit `$HOME/.bun` now emits a stderr line where it previously emitted none. Consid
Loading