paths: terminate recursive mkdir walk when a confirmed parent still yields ENOENT - #36162
Open
robobun wants to merge 13 commits into
Open
paths: terminate recursive mkdir walk when a confirmed parent still yields ENOENT#36162robobun wants to merge 13 commits into
robobun wants to merge 13 commits into
Claude / Claude Code Review
completed
Jul 28, 2026 in 11m 5s
Code review found 2 potential issues
Found 1 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/cli/install/bun-install-cache-dir.test.ts:28-48 |
bunfig install.cache.dir explicit path is untested |
Annotations
Check warning on line 48 in test/cli/install/bun-install-cache-dir.test.ts
claude / Claude Code Review
bunfig install.cache.dir explicit path is untested
Nit: `is_explicit: true` is set for two entry points — `BUN_INSTALL_CACHE_DIR` and bunfig `install.cache.dir` (`opts.cache_directory`, PackageManagerDirectories.rs:392-396) — but the tests only exercise the env-var spelling. A sibling test that writes `bunfig.toml` with `[install.cache]\ndir = "<dangling>/cache"` (no `BUN_INSTALL_CACHE_DIR`) would cover the variant matrix per REVIEW.md's "every accepted spelling of an option". Not blocking: both spellings converge on the identical `CacheDir` str
Loading