jsc: make control-flow-profiler getExecutedRanges linear instead of quadratic - #36137
Open
robobun wants to merge 8 commits into
Open
jsc: make control-flow-profiler getExecutedRanges linear instead of quadratic#36137robobun wants to merge 8 commits into
robobun wants to merge 8 commits into
Claude / Claude Code Review
completed
Jul 27, 2026 in 10m 36s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/node/inspector/inspector-profiler.test.ts:748 |
Correctness test should use test.concurrent to match sibling subprocess tests |
Annotations
Check warning on line 748 in test/js/node/inspector/inspector-profiler.test.ts
claude / Claude Code Review
Correctness test should use test.concurrent to match sibling subprocess tests
The N=120 correctness test spawns an independent subprocess but uses plain `test` — the four sibling subprocess-spawning tests in this file's `precise coverage` block all use `test.concurrent`, and REVIEW.md asks for the same on independent subprocess suites. The scaling test is reasonably left serial (running it concurrently with other CPU-bound subprocesses would add contention noise to the timing ratio), but a one-line comment saying so would satisfy the "staying serial needs a stated reason"
Loading