Windows: release FileSink keep-alive ref for Bun.file(fd).writer() on a borrowed fd - #36107
Open
robobun wants to merge 7 commits into
Open
Windows: release FileSink keep-alive ref for Bun.file(fd).writer() on a borrowed fd#36107robobun wants to merge 7 commits into
robobun wants to merge 7 commits into
Claude / Claude Code Review
completed
Jul 27, 2026 in 18m 26s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/util/filesink.test.ts:595 |
Test does not wire cp.on('error') to reject the awaited close promise |
Annotations
Check warning on line 595 in test/js/bun/util/filesink.test.ts
claude / Claude Code Review
Test does not wire cp.on('error') to reject the awaited close promise
The exit-code promise only wires `close`: `await new Promise<number>(resolve => cp.on("close", ...))`. REVIEW.md asks to wire every failure event to reject the awaited promise — add `cp.on("error", reject)` so a spawn failure surfaces as a clean assertion rejection instead of an uncaught-exception path. (Nit — `bunExe()` failing is implausible; one-line fix.)
Loading