fetch/S3: replace ResumableSink with proper JSSinks - #36087
Merged
Jarred-Sumner merged 164 commits intoJul 31, 2026
Claude / Claude Code Review
completed
Jul 27, 2026 in 8m 43s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/web/fetch/fetch.test.ts:2542 |
Vacuous assertion: stderr checked for "BUG:" but fixture writes it to stdout |
Annotations
Check warning on line 2542 in test/js/web/fetch/fetch.test.ts
claude / Claude Code Review
Vacuous assertion: stderr checked for "BUG:" but fixture writes it to stdout
This assertion is vacuous: the fixture writes its failure sentinel via `console.log("BUG: fetch resolved")`, which goes to **stdout**, so `stderr` never contains `"BUG:"` under any code path. The preceding `stringMatching(/^rejected:.../)` on stdout already fails if fetch resolves and prints the sentinel, so this line adds no coverage — just drop it.
Loading