Skip to content

fix(build): rename AnyResponse::resume_() callers to resume() #36072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 2 commits into from
Jul 27, 2026
Merged

fix(build): rename AnyResponse::resume_() callers to resume() #36072

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
841b99a
fix(build): rename AnyResponse::resume_() callers to resume()
robobun Jul 27, 2026
bbcf82a
test: paused request body is released when handler responds without r…
robobun Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/runtime/server/RequestContext.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2379,7 +2379,7 @@ where
if let Some(resp) = self.resp.take() {
if self.flags.request_body_paused() {
self.flags.set_request_body_paused(false);
resp.resume_();
resp.resume();
}
if self.flags.is_waiting_for_request_body() {
self.flags.set_is_waiting_for_request_body(false);
Expand Down Expand Up @@ -4123,7 +4123,7 @@ where
return;
}
if let Some(resp) = self.resp {
resp.resume_();
resp.resume();
}
}

Expand Down Expand Up @@ -4179,7 +4179,7 @@ where
}
}
if let Some(resp) = (*this).resp {
resp.resume_();
resp.resume();
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions src/runtime/webcore/streams.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1405,7 +1405,7 @@ impl<const SSL: bool, const HTTP3: bool> HTTPServerWritable<SSL, HTTP3> {
if let Some(res) = self.any_res() {
res.clear_on_writable();
// Release any request-body pause while `res` is live (see `end_already_responded_stream`).
res.resume_();
res.resume();
}
// `send_readable` drained the parked `try_end`, so uWS has
// `markDone()`d the response and dropped its `onAborted`.
Expand Down Expand Up @@ -1782,7 +1782,7 @@ impl<const SSL: bool, const HTTP3: bool> HTTPServerWritable<SSL, HTTP3> {

if let Some(res) = self.any_res() {
// Release any request-body pause while `res` is live (see `end_already_responded_stream`).
res.resume_();
res.resume();
}
// Both branches above fully ended the response through uWS, which
// `markDone()`s it and drops its `onAborted`.
Expand Down Expand Up @@ -1870,7 +1870,7 @@ impl<const SSL: bool, const HTTP3: bool> HTTPServerWritable<SSL, HTTP3> {
if let Some(res) = self.any_res() {
res.clear_on_writable();
// Release any request-body pause while `res` is live (see `end_already_responded_stream`).
res.resume_();
res.resume();
}
// `send_readable` drained the parked `try_end`/`end`, so uWS has
// `markDone()`d the response and dropped its `onAborted`.
Expand Down
Loading