Bun.write: deliver the full payload to a FIFO named by path - #36028
Closed
robobun wants to merge 3 commits into
Closed
Bun.write: deliver the full payload to a FIFO named by path#36028robobun wants to merge 3 commits into
robobun wants to merge 3 commits into
Claude / Claude Code Review
completed
Jul 27, 2026 in 19m 51s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/io/bun-write.test.js:738-743 |
FIFO test matrix omits the small-Uint8Array fast-path handoff |
Annotations
Check warning on line 743 in test/js/bun/io/bun-write.test.js
claude / Claude Code Review
FIFO test matrix omits the small-Uint8Array fast-path handoff
The test matrix has no <256 KiB Uint8Array case, so the new fd-handoff block in `write_bytes_to_file_fast` (Blob.rs:5548-5558) is never executed — the 1 MiB Uint8Array exceeds the 256 KiB threshold at Blob.rs:5109 and skips the fast path entirely. Add `["200 KiB Uint8Array", "u8", 200 * 1024]` to the `it.each` matrix so both sibling entry points receiving the same fix are covered; without it, deleting that handoff block would not break any test.
Loading