event_loop: don't debug-panic on late main-VM enqueue_task_concurrent during process.exit - #36020
Open
robobun wants to merge 6 commits into
Open
event_loop: don't debug-panic on late main-VM enqueue_task_concurrent during process.exit#36020robobun wants to merge 6 commits into
robobun wants to merge 6 commits into
Claude / Claude Code Review
completed
Jul 26, 2026 in 14m 48s
Code review found 3 potential issues
Found 1 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 3 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/node/fs/fs-write-exit-race.test.ts:67-72 |
Poll loop falls through on deadline without asserting the precondition |
Annotations
Check warning on line 72 in test/js/node/fs/fs-write-exit-race.test.ts
claude / Claude Code Review
Poll loop falls through on deadline without asserting the precondition
The bounded poll loop at lines 68-72 falls through silently on deadline expiry — if `Date.now()` reaches `deadline` without `fs.readSync` returning >0, the fixture proceeds straight to `process.exit(0)` without asserting the writer ever entered the kernel. Per REVIEW.md's "assert that setup created the precondition" rule, track a `let sawBytes = false;` flag set inside the `> 0` branch and, after the loop, `if (!sawBytes) { process.stderr.write("writer never entered kernel\n"); process.exit(1);
Loading