Skip to content

event_loop: don't debug-panic on late main-VM enqueue_task_concurrent during process.exit - #36020

Open
robobun wants to merge 6 commits into
mainfrom
farm/b37fdd39/enqueue-task-concurrent-main-vm-exit
Open

event_loop: don't debug-panic on late main-VM enqueue_task_concurrent during process.exit#36020
robobun wants to merge 6 commits into
mainfrom
farm/b37fdd39/enqueue-task-concurrent-main-vm-exit

test: gate on isASAN and poll for writer-in-kernel instead of sleeping

be3956b
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Jul 26, 2026 in 14m 48s

Code review found 3 potential issues

Found 1 candidates, confirmed 3. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 3
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit test/js/node/fs/fs-write-exit-race.test.ts:67-72 Poll loop falls through on deadline without asserting the precondition

Annotations

Check warning on line 72 in test/js/node/fs/fs-write-exit-race.test.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Poll loop falls through on deadline without asserting the precondition

The bounded poll loop at lines 68-72 falls through silently on deadline expiry — if `Date.now()` reaches `deadline` without `fs.readSync` returning >0, the fixture proceeds straight to `process.exit(0)` without asserting the writer ever entered the kernel. Per REVIEW.md's "assert that setup created the precondition" rule, track a `let sawBytes = false;` flag set inside the `> 0` branch and, after the loop, `if (!sawBytes) { process.stderr.write("writer never entered kernel\n"); process.exit(1);