fix(sqlite): bind template values positionally to prevent SQL injection - #35963
Closed
baima365-web wants to merge 1 commit into
Closed
fix(sqlite): bind template values positionally to prevent SQL injection#35963baima365-web wants to merge 1 commit into
baima365-web wants to merge 1 commit into
Conversation
SQLiteQueryHandle.run was using $apply to forward positional parameters, which let attacker-controlled objects/arrays override trusted bindings. Fix: Check if values is array and bind positionally instead of using $apply. Fixes oven-sh#35950
Collaborator
|
Thanks for the report and for the fix. The same change landed on main in #35950: Closing this one as superseded by #35950. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
SQLiteQueryHandle.runwas using$applyto forward positional parameters, which let attacker-controlled objects/arrays override trusted bindings.Problem
Fix
Check if values is array and bind positionally instead of using
$apply. This prevents objects/arrays from being misinterpreted as named binding maps.Fixes #35950