node:fs: pin the directory fd at opendir time - #35928
Open
robobun wants to merge 11 commits into
Open
Claude / Claude Code Review
completed
Jul 26, 2026 in 18m 32s
Code review found 2 important issues
Found 1 candidates, confirmed 4. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 2 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/runtime/dispatch.rs:46 |
Stale '42' count in dispatch.rs inline comments |
Annotations
Check warning on line 46 in src/runtime/dispatch.rs
claude / Claude Code Review
Stale '42' count in dispatch.rs inline comments
The doc comment here was bumped to "44 `node:fs` async ops", but two inline comments further down in `run_task` still say **42**: line ~390 (`// 42 arms stamped from `for_each_fs_async_op!``) and line ~397 (`// SAFETY: outer arm guard proves one of the 42 tags matched`). Bump them to 44 — or better, drop the hard-coded count so it can't drift again.
Loading