runtime: one module record for a .json imported with and without the type attribute - #35914
Open
robobun wants to merge 6 commits into
Open
runtime: one module record for a .json imported with and without the type attribute#35914robobun wants to merge 6 commits into
robobun wants to merge 6 commits into
Claude / Claude Code Review
completed
Jul 26, 2026 in 24m 3s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/resolve/json-import-identity.test.ts:28 |
14 independent subprocess tests should use test.concurrent |
Annotations
Check warning on line 28 in test/js/bun/resolve/json-import-identity.test.ts
claude / Claude Code Review
14 independent subprocess tests should use test.concurrent
nit: All 14 tests here spawn independent subprocesses via `run()` (each with its own `tempDir`, no shared state), so they should use `test.concurrent` — 14 serial debug+ASAN spawns will push this file well past the ~10s budget. See sibling `test/js/bun/resolve/bun-main-entry-point.test.ts` for the same pattern.
Loading