BigInt("0x…"/"0b…"/"0o…"): linear-time string parse - #35899
Open
robobun wants to merge 3 commits into
Open
Claude / Claude Code Review
completed
Jul 26, 2026 in 9m 13s
Code review found 1 important issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | scripts/build/deps/webkit.ts:6 |
WEBKIT_VERSION points to unmerged preview build |
Annotations
Check failure on line 6 in scripts/build/deps/webkit.ts
claude / Claude Code Review
WEBKIT_VERSION points to unmerged preview build
`WEBKIT_VERSION` is pointing at `autobuild-preview-pr-353-4b51ec68`, an ephemeral preview-build release for the still-unmerged oven-sh/WebKit#353. Preview releases are deleted once the upstream PR merges/closes, at which point every fresh prebuilt-mode build (CI and local) will 404 on the WebKit download. Per the description this is a known TODO — flagging so it doesn't slip: bump to the merged commit sha before landing.
Loading