redis: give SubscriptionCtx an explicit BackRef to fix the subscribe() refcount over-release - #35787
Open
robobun wants to merge 5 commits into
Open
redis: give SubscriptionCtx an explicit BackRef to fix the subscribe() refcount over-release#35787robobun wants to merge 5 commits into
robobun wants to merge 5 commits into
Claude / Claude Code Review
completed
Jul 25, 2026 in 24m 51s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/valkey/valkey-gc.test.ts:127-145 |
New test inserted between an existing comment and its test, orphaning the comment |
Annotations
Check warning on line 145 in test/js/valkey/valkey-gc.test.ts
claude / Claude Code Review
New test inserted between an existing comment and its test, orphaning the comment
The new healthy-server test and its comment block are inserted immediately after line 129 ("This variant races a server-side RST against subscribe()+close().") with no separating blank line, so the pre-existing 5-line RST comment now reads as part of the healthy-server test's header — while the actual RST test at ~line 217 is left with no adjacent descriptive comment. Move the new test (and its comment) to *before* the "Fuzzer found the same over-release reachable from subscribe()..." block, or
Loading