jsc: treat BunTranspiledModule as Module in JSC debugger/inspector switches - #35754
Closed
robobun wants to merge 8 commits into
Closed
jsc: treat BunTranspiledModule as Module in JSC debugger/inspector switches#35754robobun wants to merge 8 commits into
robobun wants to merge 8 commits into
Claude / Claude Code Review
completed
Jul 26, 2026 in 11m 17s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/cli/inspect/debugger-buntranspiledmodule.test.ts:222-236 |
skipIf(isASAN) also skips test under default local 'bun bd' debug build |
Annotations
Check warning on line 236 in test/cli/inspect/debugger-buntranspiledmodule.test.ts
claude / Claude Code Review
skipIf(isASAN) also skips test under default local 'bun bd' debug build
The file comment says "Skipped under the CI ASAN build", but `.skipIf(isASAN)` is broader than that: `isASAN` now probes the compiled `ASAN_ENABLED` flag (harness.ts:48-62), and the default `bun bd` debug profile enables ASAN on Linux and arm64 macOS (scripts/build/config.ts:770), so `bun bd test <this file>` on those platforms reports both cases as `(skip)` — even though the PR's own evidence block shows them passing under debug+ASAN at 92f231529. The narrower repo pattern for a CI-ASAN-only fl
Loading