runtime transpiler cache: per-uid root, ownership check, mandatory payload hashes - #35747
Open
robobun wants to merge 7 commits into
Open
runtime transpiler cache: per-uid root, ownership check, mandatory payload hashes#35747robobun wants to merge 7 commits into
robobun wants to merge 7 commits into
Claude / Claude Code Review
completed
Aug 20, 2026 in 17m 36s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/RuntimeTranspilerCache.rs:751-754 |
Stale @t@ leaf name in shared-tmpdir fallback test weakens its assertion |
Annotations
Check warning on line 754 in src/jsc/RuntimeTranspilerCache.rs
claude / Claude Code Review
Stale @t@ leaf name in shared-tmpdir fallback test weakens its assertion
The pre-existing "disables the cache instead of falling back to the shared temp directory" test still pre-creates and asserts on `join(shared_tmp, "bun", "@t@")`, but this PR renames the default leaf to `@t@-<uid>`. If a TMPDIR fallback were ever re-added it would write to `shared_tmp/bun/@t@-<uid>`, leaving the asserted `@t@` directory empty — the assertion can no longer fail for the regression it guards. Consider asserting `readdirSync(join(shared_tmp, "bun"))` equals `["@t@"]` (only the pre
Loading