node:inspector: emit full RemoteObject, stackTrace, and count/time*/assert/dirxml/clear for in-process Session consoleAPICalled - #35743
Open
robobun wants to merge 7 commits into
Claude / Claude Code Review
completed
Jul 25, 2026 in 42m 1s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/js/node/inspector.ts:612-623 |
time*/countReset hooks omit V8's type:"warning" event on missing/duplicate label |
Annotations
Check warning on line 623 in src/js/node/inspector.ts
claude / Claude Code Review
time*/countReset hooks omit V8's type:"warning" event on missing/duplicate label
The `time`/`timeLog`/`timeEnd`/`countReset` hooks silently skip emitting when the label is missing or duplicate, but V8's `V8Console::Time`/`TimeLog`/`TimeEnd`/`CountReset` each emit a `Runtime.consoleAPICalled` with `type:"warning"` on exactly these paths ("Timer '…' already exists", "Timer '…' does not exist", "Count for '…' does not exist"), so a Node in-process Session listener receives them. Since this PR's goal is matching V8's consoleAPICalled shape for these newly-hooked methods (and the
Loading