js_printer: fix require("bun") and other printer literals being captured by same-named locals - #35739
Open
robobun wants to merge 10 commits into
Open
js_printer: fix require("bun") and other printer literals being captured by same-named locals#35739robobun wants to merge 10 commits into
robobun wants to merge 10 commits into
Claude / Claude Code Review
completed
Jul 25, 2026 in 18m 43s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/resolve/import-meta.test.js:244-259 |
New subprocess-spawning tests should use describe.concurrent |
Annotations
Check warning on line 259 in test/js/bun/resolve/import-meta.test.js
claude / Claude Code Review
New subprocess-spawning tests should use describe.concurrent
These five new tests each spawn an independent subprocess in an isolated `tempDir` with no shared state, so this block can be `describe.concurrent` (per REVIEW.md harness conventions: "`test.concurrent` for independent subprocess suites"). Serial spawns compound under debug+ASAN's 10-100× slowdown; running them concurrently is free wall-clock.
Loading