s3: resolve streamed write/download with the byte count, not 0 - #35671
Open
robobun wants to merge 8 commits into
Open
s3: resolve streamed write/download with the byte count, not 0#35671robobun wants to merge 8 commits into
robobun wants to merge 8 commits into
Claude / Claude Code Review
completed
Jul 25, 2026 in 20m 23s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/s3/s3-write-return-bytes.test.ts:126 |
Redundant manual server.stop(true) alongside using server |
Annotations
Check warning on line 126 in test/js/bun/s3/s3-write-return-bytes.test.ts
claude / Claude Code Review
Redundant manual server.stop(true) alongside `using server`
This test declares `using server = Bun.serve({...})` at line 94, which already stops the server at scope exit via `Symbol.dispose`, so the explicit `server.stop(true)` here is a redundant double-close. REVIEW.md's hermetic-tests rule explicitly forbids "manual close alongside `using`", and every other test in this file relies solely on `using` for cleanup — drop this line and let the `using` declaration handle disposal.
Loading