install: warn when a link: dependency declares peerDependencies - #35602
Open
robobun wants to merge 9 commits into
Open
install: warn when a link: dependency declares peerDependencies#35602robobun wants to merge 9 commits into
robobun wants to merge 9 commits into
Claude / Claude Code Review
completed
Jul 25, 2026 in 17m 46s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/cli/install/bun-link.test.ts:526-539 |
--silent suppression case dropped from test in 490dc6e |
Annotations
Check warning on line 539 in test/cli/install/bun-link.test.ts
claude / Claude Code Review
--silent suppression case dropped from test in 490dc6e
Commit 490dc6e dropped the `--silent` sub-block from this test, so the `pm.options.log_level != LogLevel::Silent` gate at `Package.rs:2226` now ships with zero coverage — and the PR description's Test section still lists "`--silent` suppresses the warning" as covered. Either restore a one-line `run([bunExe(), "link", "--silent", link_name], package_dir)` case asserting `err` does not contain the header, or drop the stale bullet from the PR body.
Loading