Skip to content

Bun.Transpiler: default autoImportJSX to true for the automatic runtime - #35557

Open
robobun wants to merge 15 commits into
mainfrom
farm/5470f44d/transpiler-auto-import-jsx-default
Open

Bun.Transpiler: default autoImportJSX to true for the automatic runtime#35557
robobun wants to merge 15 commits into
mainfrom
farm/5470f44d/transpiler-auto-import-jsx-default

scanImports: mirror the auto-import gate so it agrees with scan()

c3c0717
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Jul 27, 2026 in 9m 29s

Code review found 2 potential issues

Found 5 candidates, confirmed 2. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 2
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit src/js_parser/parse/parse_entry.rs:483-485 Multi-line comment in parse_entry.rs still tripping comment-cop
🟡 Nit test/bundler/transpiler/transpiler.test.js:2276-2279 Bug-history narration comment on inner scanImports describe block

Annotations

Check warning on line 485 in src/js_parser/parse/parse_entry.rs

See this annotation in the file changed.

@claude claude / Claude Code Review

Multi-line comment in parse_entry.rs still tripping comment-cop

comment-cop is still flagging this 3-line comment (unresolved github-actions inline on line 485, posted after c3c07173). Lines 2-3 ("Mirror the full-parse auto-import gate so scanImports() and scan() agree…") narrate what the code does and appear verbatim in the PR description; the durable non-obvious content is line 1 alone. Trim to just `// Symbol use counts are unavailable, so "any JSX parsed?" is the proxy.` — same shape as the JSTranspiler.rs comment-cop fix in dbfb1e8f70.

Check warning on line 2279 in test/bundler/transpiler/transpiler.test.js

See this annotation in the file changed.

@claude claude / Claude Code Review

Bug-history narration comment on inner scanImports describe block

Per REVIEW.md, regression tests get exactly one comment (the issue URL) with no bug-history narration. The 4-line "scanImports() used to … It now mirrors …" comment on this inner describe is the same pattern an earlier review round already flagged and fixed on the outer block; the outer block already carries the issue URL and this describe's title already states what's tested — drop the comment.