fetch: honour Connection: close on non-2xx responses and HTTP/1.0 defaults in the keep-alive pool - #35545
Closed
robobun wants to merge 5 commits into
Closed
fetch: honour Connection: close on non-2xx responses and HTTP/1.0 defaults in the keep-alive pool#35545robobun wants to merge 5 commits into
robobun wants to merge 5 commits into
Claude / Claude Code Review
completed
Jul 25, 2026 in 15m 27s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/web/fetch/fetch-keepalive.test.ts:329-334 |
New tests split a paired positive/negative test, breaking the 'gate above' comment reference |
Annotations
Check warning on line 334 in test/js/web/fetch/fetch-keepalive.test.ts
claude / Claude Code Review
New tests split a paired positive/negative test, breaking the 'gate above' comment reference
The two new tests are inserted between `"an early response to a streaming POST closes the socket..."` and its paired negative-contract test, whose header comment reads `// Negative contract for the gate above: a streamed POST whose chunked body completed...`. That positional "the gate above" now points at the unrelated CONNECT-proxy test instead of the streaming-POST test it was written against — either move the new tests after the negative-contract test (or before the pair) so the two stay adja
Loading