redis: implement psubscribe/punsubscribe with listener routing - #35521
Open
robobun wants to merge 8 commits into
Open
redis: implement psubscribe/punsubscribe with listener routing#35521robobun wants to merge 8 commits into
robobun wants to merge 8 commits into
Claude / Claude Code Review
completed
Jul 25, 2026 in 22m 0s
Code review found 2 potential issues
Found 1 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | packages/bun-types/redis.d.ts:2797-2802 |
subscribe() JSDoc omits psubscribe/punsubscribe from allowed-while-subscribed list |
Annotations
Check warning on line 2802 in packages/bun-types/redis.d.ts
claude / Claude Code Review
subscribe() JSDoc omits psubscribe/punsubscribe from allowed-while-subscribed list
The new `psubscribe()` JSDoc correctly lists all five commands allowed in subscriber mode (`.ping()`, `.subscribe()`, `.unsubscribe()`, `.psubscribe()`, `.punsubscribe()`), but the pre-existing `subscribe()` JSDoc just above it (redis.d.ts:2697-2699) still says only `.ping()`, `.subscribe()`, and `.unsubscribe()` are allowed. Since this PR makes the pattern methods first-class subscriber-mode commands and writes the correct five-item list in the new block, worth updating the adjacent `subscribe(
Loading