node:http: keep delivering the request body after a synchronous res.end() - #35489
Closed
robobun wants to merge 13 commits into
Closed
node:http: keep delivering the request body after a synchronous res.end()#35489robobun wants to merge 13 commits into
robobun wants to merge 13 commits into
Claude / Claude Code Review
completed
Aug 1, 2026 in 25m 47s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/node/http/node-http.test.ts:4239 |
Explicit per-test timeouts violate test/CLAUDE.md |
Annotations
Check warning on line 4239 in test/js/node/http/node-http.test.ts
claude / Claude Code Review
Explicit per-test timeouts violate test/CLAUDE.md
The two new subprocess-spawning tests pass explicit `20_000` per-test timeouts (here and at :4307), which `test/CLAUDE.md:120` marks as **CRITICAL**: "Do not set a timeout on tests. Bun already has timeouts." Both tests do trivial loopback HTTP work in a spawned `bunExe()`; drop the explicit timeouts and let the file default apply (or, if debug+ASAN startup genuinely needs the headroom, that's the case for a file-level default rather than per-test overrides).
Loading