Remove dead code from C++ bindings, src/js builtins, CSS, and Rust util crates - #35437
Open
robobun wants to merge 10 commits into
Open
Remove dead code from C++ bindings, src/js builtins, CSS, and Rust util crates#35437robobun wants to merge 10 commits into
robobun wants to merge 10 commits into
Claude / Claude Code Review
completed
Aug 2, 2026 in 21m 8s
Code review found 2 potential issues
Found 3 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/js/internal/http.ts:46-47 |
http.ts dead-symbol sweep missed kPath and kOptions |
| 🟡 Nit | src/css/dependencies.rs:1 |
dependencies.rs module doc still names 'url() values' after Url.loc removal |
Annotations
Check warning on line 47 in src/js/internal/http.ts
claude / Claude Code Review
http.ts dead-symbol sweep missed kPath and kOptions
The dead-Symbol sweep in this file missed two more that meet the identical criterion: `kPath` (line 46, exported line 582) and `kOptions` (line 47, exported line 580) are declared and exported but never imported anywhere — `_http_client.ts:62` and `http2.ts:45` each define their *own* local `kPath`/`kOptions` Symbols, not imports from here. Per REVIEW.md "Fix the whole class in the same PR", these should be removed alongside the 27 siblings (`kPort`, `kMethod`, `kHost`, etc.) that sat directly a
Check warning on line 1 in src/css/dependencies.rs
claude / Claude Code Review
dependencies.rs module doc still names 'url() values' after Url.loc removal
Commit 0eb58df removed `Url.loc` (addressing the earlier write-only-field comment), so `dependencies::Location` is no longer stored on any `url()` value — its only remaining users are `Composes.cssparser_loc` (properties/css_modules.rs:21,52) and `Printer::new_error`'s `maybe_loc` param. The module doc this PR wrote at `src/css/dependencies.rs:1` ("Source location for CSS `url()` values and printer errors") is now stale on the "`url()` values" clause — same within-PR cascade class as the already
Loading