test(spawn): speed up spawn-noread-leak.test.ts (27s -> 2s on Windows arm64) - #35427
Open
robobun wants to merge 3 commits into
Open
test(spawn): speed up spawn-noread-leak.test.ts (27s -> 2s on Windows arm64)#35427robobun wants to merge 3 commits into
robobun wants to merge 3 commits into
Claude / Claude Code Review
completed
Jul 24, 2026 in 10m 53s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/spawn/spawn-noread-leak.test.ts:68-72 |
Comment states ASAN delta is ~10 MB but measurements show ~15-16 MB |
Annotations
Check warning on line 72 in test/js/bun/spawn/spawn-noread-leak.test.ts
claude / Claude Code Review
Comment states ASAN delta is ~10 MB but measurements show ~15-16 MB
The comment says "the delta there is ~10 MB" for ASAN, but the PR description's own measurements table shows +15.0/+15.0/+16.0/+15.0/+16.0 MB (and the description prose says "~15 MB"). Should read ~15 MB so the stated headroom to the 30 MB limit reflects the actual ~2x margin rather than an implied ~3x. (Minor secondary nit on line 13: `cmd /c echo x` writes 3 bytes on Windows — `x\r\n` — not two.)
Loading