Skip to content

assert: node v26 deep-equality fidelity — loose mode, errors, set/map pairing (+0 tests, correctness only) #35393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cirospaciari wants to merge 3 commits into from
Closed

assert: node v26 deep-equality fidelity — loose mode, errors, set/map pairing (+0 tests, correctness only) #35393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9306ce
assert: give deepEqual node's loose comparison semantics
cirospaciari Jul 24, 2026
280e3d6
assert: pair set and map entries off instead of matching them repeatedly
cirospaciari Jul 24, 2026
d1e9ec5
assert: drop stray blank line
cirospaciari Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/js/internal/util/comparisons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,8 @@
// kStrictWithoutPrototypes mode). node v26.3.0 exposes fn.length === 3.
const isDeepStrictEqual = $newCppFunction("NodeUtilTypesModule.cpp", "jsFunctionIsDeepStrictEqual", 3);

export default { isDeepStrictEqual };
// node's loose mode, behind assert.deepEqual / assert.notDeepEqual. Not the
// same relation as Bun.deepEquals(a, b, false), which expect() uses.
const isDeepEqual = $newCppFunction("NodeUtilTypesModule.cpp", "jsFunctionIsDeepEqual", 2);

export default { isDeepStrictEqual, isDeepEqual };
6 changes: 1 addition & 5 deletions src/js/node/assert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,7 @@ type nodeAssert = typeof import("node:assert");

const kOptions = Symbol("options");

const { isDeepStrictEqual } = require("internal/util/comparisons");

function isDeepEqual(a, b) {
return Bun.deepEquals(a, b, false);
}
const { isDeepStrictEqual, isDeepEqual } = require("internal/util/comparisons");

var _inspect;
function lazyInspect() {
Expand Down
Loading
Loading