refactor(rust): remove resolved borrowck-reshape comments (bucket A, 256 sites) - #35360
Open
robobun wants to merge 8 commits into
Open
refactor(rust): remove resolved borrowck-reshape comments (bucket A, 256 sites)#35360robobun wants to merge 8 commits into
robobun wants to merge 8 commits into
Claude / Claude Code Review
completed
Jul 24, 2026 in 16m 36s
Code review found 1 important issue
Found 1 candidates, confirmed 4. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 3 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/bundler/bundle_v2.rs:6441-6444 |
Duplicate SAFETY headers stacked on the same unsafe block |
Annotations
Check warning on line 6444 in src/bundler/bundle_v2.rs
claude / Claude Code Review
Duplicate SAFETY headers stacked on the same unsafe block
The new A2 SAFETY comment (6441-6443) is stacked directly on top of the pre-existing one-line SAFETY (6444), so this `unsafe { ParentRef::from_raw_mut(...) }` now has two back-to-back `// SAFETY:` headers stating the same write-provenance + outlives-ParseTask invariant. Unlike the other A2 sites in this file (1132, 1265) where the new comment annotates the safe `from_mut` line and the pre-existing SAFETY covers a *separate* unsafe block, here both annotate the same unsafe — suggest merging into
Loading