Skip to content

node:fs: fix FileHandle.readableWebStream BYOB read into a subarray view #35355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 2 commits into
base: main
Choose a base branch
from
Open

node:fs: fix FileHandle.readableWebStream BYOB read into a subarray view #35355

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9a5b1c
node:fs: fix FileHandle.readableWebStream BYOB read into a subarray view
robobun Jul 24, 2026
7712f66
ci: retrigger
robobun Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/js/node/fs.promises.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ function asyncWrap(fn: any, name: string) {

let bytesRead;
try {
({ bytesRead } = await handle.read(view, view.byteOffset, view.byteLength));
({ bytesRead } = await handle.read(view, 0, view.byteLength));
} catch (err) {
if (done) return;
await ondone();
Expand Down
17 changes: 17 additions & 0 deletions test/js/node/fs/fs.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,23 @@ describe("FileHandle", () => {
reader.releaseLock();
});

it("FileHandle#readableWebStream BYOB reader accepts a subarray view", async () => {
using dir = tempDir("fh-readablewebstream-byob", {
"data.bin": Buffer.alloc(200, "X").toString(),
});
await using fh = await fs.promises.open(join(String(dir), "data.bin"));
const reader = fh.readableWebStream().getReader({ mode: "byob" });

const backing = new ArrayBuffer(1000);
const { value, done } = await reader.read(new Uint8Array(backing, 500, 100));

expect(done).toBe(false);
expect(value.byteOffset).toBe(500);
expect(value.byteLength).toBe(100);
expect(Buffer.from(value).toString()).toBe(Buffer.alloc(100, "X").toString());
reader.releaseLock();
});

it("FileHandle#createReadStream", async () => {
await using fd = await fs.promises.open(__filename);
const readable = fd.createReadStream();
Expand Down
Loading